This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
fix bugs: #727
Open
fix bugs: #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shavidzet
suggested changes
Nov 1, 2018
template/.electron-vue/dev-runner.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| 'use strict' | |||
|
|
|||
| process.env.NODE_ENV = 'production' | |||
There was a problem hiding this comment.
I don't think it's right way to fix this bug.
There was a problem hiding this comment.
So stupid mistake!
Thank you for reminding me. I have fixed it. Is this the desired result now?
There was a problem hiding this comment.
process.env.NODE_ENVis undefined in.eslintrc.jsin development mode, because we are not passing string while linter runs, but for production it readsproductionas string, it works how it should and.eslintrc.jsdoesn't need changes.- Highlighted third line in your code, I think is wrong way to pass data for NODE_ENV, you can do it same way as we did for production:
electron-vue/template/package.json
Line 34 in 8fae476
right example:
cross-env NODE_ENV=development webpack --progress --colors --config .electron-vue/webpack.renderer.config.js
Conclusion:
debugger for development environment already works fine and currently we have only two mode for NODE_ENV: development & production, in most cases NODE_ENV is undefined because we start coding from development and then we separate environment for production.
I hope you understand idea
sorry for my careless
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
process.env.NODE_ENVis never set todevelopmentin the project.Only run
npm run buildwill get correct value ofprocess.env.NODE_ENV, other command will getundefined.I want to lint
no-debuggerwhen runnpm run lintornpm run buildbut not lintno-debuggerwhen runnpm run dev.(EsLint is going to read the.eslintrc.jsfile very early on, so to set the value ofprocess.env.NODE_ENVbefore that, set the value indev-runnerfile).Sorry for my poor English...